fix: log progress tracker refresh errors instead of silently swallowing - #3975
Merged
mnriem merged 2 commits intoAug 13, 2026
Merged
Conversation
The bare 'except Exception: pass' in StepTracker._maybe_refresh() completely hid rendering bugs in the Rich progress display. Now logs at DEBUG level with full traceback for diagnostics.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DEBUG-level traceback logging for suppressed progress refresh failures.
Changes:
- Introduces a module logger.
- Logs refresh callback exceptions with traceback details.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_console.py |
Logs StepTracker refresh failures for diagnostics. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
- Test that _maybe_refresh logs exceptions instead of silently swallowing - Verify diagnostic message and traceback are recorded in DEBUG logs - Confirm tracker update completes normally despite refresh callback failure Requested by Copilot in PR github#3975
Collaborator
|
Thank you! |
ira-at-work
added a commit
to ira-at-work/spec-kit
that referenced
this pull request
Aug 17, 2026
* main: (27 commits) Add SpecAssay bundle to community catalog (github#4125) chore: release 0.16.4, begin 0.16.5.dev0 development (github#4124) Add SpecAssay preset to community catalog (github#4123) Update Intake Authoring Governance preset to v0.3.1 (github#4121) Update Superspec extension to v1.0.2 (github#4120) fix(taskstoissues): widen task-ID regex to match IDs longer than 3 digits (github#4101) Add Architecture Governance extension to community catalog (github#4122) fix(workflows): validate non-string step types (github#4111) Harden community submission workflow output allowlists (github#4103) chore(deps): bump github/codeql-action (init + analyze) from 4.37.5 to 4.37.6 (github#4114) Add SpecAssay Check extension to community catalog (github#4113) fix(integrations): dispatch goose commands via `goose run` (github#2416) (github#3781) fix(powershell): stop Out-Null swallowing the AVAILABLE_DOCS status lines (github#3891) fix: remove TOCTOU race in RunState.load (github#3839) fix: decode the zipped manifest as UTF-8 before parsing (github#3958) Update Agent Parity Governance preset to v0.4.2 (github#4110) fix: log progress tracker refresh errors instead of silently swallowing (github#3975) [extension] Add SpecJudge extension to community catalog (github#4079) fix(bundler): read the authoritative `default_integration` field, not only its legacy aliases (github#3880) fix(auth): treat exact host patterns literally (github#4108) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bare except Exception: pass in StepTracker._maybe_refresh() completely hid rendering bugs in the Rich progress display.
Fix
Now logs at DEBUG level with full traceback for diagnostics.